Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 9, 2025

Fixes TOOL-2994

@vercel
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:40am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:40am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:40am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 9:40am

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: ab70402

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Jan 9, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title fix: PayEmbed purchase callback and insufficient funds display [SDK] fix: PayEmbed purchase callback and insufficient funds display Jan 9, 2025
@joaquim-verges joaquim-verges changed the title [SDK] fix: PayEmbed purchase callback and insufficient funds display fix: PayEmbed purchase callback and insufficient funds display Jan 9, 2025
@joaquim-verges joaquim-verges changed the title fix: PayEmbed purchase callback and insufficient funds display [SDK] Fix: PayEmbed purchase callback and insufficient funds display Jan 9, 2025
@linear
Copy link

linear bot commented Jan 9, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 500 ms (+37.49% 🔺) 1.5 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 986 ms (+22.17% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 160 ms (+178.14% 🔺) 272 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 54 ms (+634.8% 🔺) 64 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 229 ms (+175.53% 🔺) 613 ms

@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 54.82%. Comparing base (bfc4778) to head (ab70402).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 0.00% 7 Missing ⚠️
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5918      +/-   ##
==========================================
- Coverage   54.82%   54.82%   -0.01%     
==========================================
  Files        1141     1141              
  Lines       60877    60887      +10     
  Branches     5124     5124              
==========================================
+ Hits        33376    33381       +5     
- Misses      26775    26780       +5     
  Partials      726      726              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from bfc4778
packages 52.46% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...react/core/hooks/transaction/useSendTransaction.ts 7.27% <ø> (ø)
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 0.75% <0.00%> (-0.02%) ⬇️
packages/thirdweb/src/react/web/ui/PayEmbed.tsx 36.78% <0.00%> (-2.73%) ⬇️

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 5d71415 into main Jan 9, 2025
34 of 39 checks passed
@joaquim-verges joaquim-verges deleted the fix_PayEmbed_purchase_callback_and_insufficient_funds_display branch January 9, 2025 09:41
@jnsdls jnsdls mentioned this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants